Cluster autoscaling compute #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themantissa
reviewed
May 18, 2020
Collaborator
themantissa
left a comment
themantissa
left a comment
There was a problem hiding this comment.
Single comment to ensure the test example makes sense but otherwise looks good.
gssbzn
previously approved these changes
May 19, 2020
Contributor
gssbzn
left a comment
gssbzn
left a comment
There was a problem hiding this comment.
from a code perspective LGTM but I'm not that familiar with atlas autoscaling
themantissa
approved these changes
May 19, 2020
Collaborator
themantissa
left a comment
themantissa
left a comment
There was a problem hiding this comment.
LGTM just needs a DoU approval!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fields for autoscaling
Added a new sruct Compute and its fields