Skip to content

Conversation

@kmruiz
Copy link
Collaborator

@kmruiz kmruiz commented Oct 23, 2024

Description

We don't have a reliable way to test how @Query works right now due to the error we are having in our test configuration related to injected languages. Due to this, we skip INTELLIJ-115 (the actual parsing of the query) and we do 114 and 117 which are more related to metadata of the query.

Checklist

Open Questions

@kmruiz kmruiz requested a review from himanshusinghs October 23, 2024 11:29
@kmruiz kmruiz self-assigned this Oct 23, 2024
@github-actions github-actions bot added the feature Adds a new feature. label Oct 23, 2024
@github-actions
Copy link

github-actions bot commented Oct 23, 2024

Coverage Report

Overall Project 77.23% -2.72%
Files changed 33.54% 🚫

File Coverage
SpringAtQueryDialect.kt 70.83% -29.17% 🚫
MdbEditorService.kt 54.46%
SpringAtQueryDialectParser.kt 30.98% -67.35% 🚫

@kmruiz kmruiz changed the title feat: support for the @Query operator INTELLIJ-115 feat: basic support for the @Query annotation INTELLIJ-114/INTELLIJ-117 Oct 23, 2024
@kmruiz kmruiz marked this pull request as ready for review October 23, 2024 15:17
Copy link
Contributor

@himanshusinghs himanshusinghs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, looks good!

@kmruiz kmruiz merged commit fa85b39 into main Oct 24, 2024
11 checks passed
@kmruiz kmruiz deleted the feat/INTELLIJ-115 branch October 24, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Adds a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants