works

Author: baileympearson

src/objectid.ts

@@ -32,6 +32,9 @@ export class ObjectId extends BSONValue {
   /** @internal */
   private static index = Math.floor(Math.random() * 0xffffff);
 
+  /**
+   * Enables caching of hex string representations of ObjectIds.
+   */
   static cacheHexString: boolean = true;
 
   /** ObjectId Bytes @internal */
@@ -44,15 +47,7 @@ export class ObjectId extends BSONValue {
    * not sufficient to determine if caching is enabled.  `ObjectId.prototype.isCached()` can be used to
    * determine if the hex string has been cached yet for an ObjectId.
    */
-  #_hexString: string | null = null;
-
-  get #hexString(): string | null {
-    return this.#_hexString;
-  }
-
-  set #hexString(s: string) {
-    this.#_hexString = s.toLowerCase();
-  }
+  #cachedHexString: string | null = null;
 
   /** To generate a new ObjectId, use ObjectId() with no argument. */
   constructor();
@@ -121,7 +116,7 @@ export class ObjectId extends BSONValue {
         this.buffer = ByteUtils.fromHex(workingId);
         // If we are caching the hex string
         if (ObjectId.cacheHexString) {
-          this.#hexString = workingId;
+          this.#cachedHexString = workingId.toLowerCase();
         }
       } else {
         throw new BSONError(
@@ -144,7 +139,7 @@ export class ObjectId extends BSONValue {
   set id(value: Uint8Array) {
     this.buffer = value;
     if (ObjectId.cacheHexString) {
-      this.#hexString = ByteUtils.toHex(value);
+      this.#cachedHexString = ByteUtils.toHex(value);
     }
   }
 
@@ -173,12 +168,12 @@ export class ObjectId extends BSONValue {
 
   /** Returns the ObjectId id as a 24 lowercase character hex string representation */
   toHexString(): string {
-    if (this.#hexString) return this.#hexString;
+    if (this.#cachedHexString) return this.#cachedHexString.toLowerCase();
 
     const hexString = ByteUtils.toHex(this.id);
 
     if (ObjectId.cacheHexString) {
-      this.#hexString = hexString;
+      this.#cachedHexString = hexString;
     }
 
     return hexString;
@@ -382,7 +377,7 @@ export class ObjectId extends BSONValue {
    * used for testing
    */
   private isCached(): boolean {
-    return ObjectId.cacheHexString && this.#hexString != null;
+    return ObjectId.cacheHexString && this.#cachedHexString != null;
   }
 
   /**