Skip to content

Conversation

@baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Oct 15, 2025

Description

Summary of Changes

BSON no longer vendors atob, btoa and TextEncoder for react native builds.

Notes for Reviewers

Testing available in https://github.com/baileympearson/bson-rn-vendor-polyfill-removal-test.

Example passing tests (note the console output in VSCode):

Screenshot 2025-10-15 at 3 01 08 PM

What is the motivation for this change?

Release Highlight

BSON no longer vendors atob, btoa and TextEncoder for react native builds

The React Native JS engine (Hermes) now supports atob, btoa and TextEncoder natively and polyfills are no longer needed. BSON no longer includes these polyfills for react native builds.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title remove RN vendor polyfills feat(NODE-7019): remove react native vendor polyfills Oct 15, 2025
@baileympearson baileympearson marked this pull request as ready for review October 15, 2025 21:05
@baileympearson baileympearson requested a review from a team as a code owner October 15, 2025 21:05
@durran durran self-assigned this Oct 17, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 17, 2025
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 conflict in the rollup config.

@durran durran merged commit 883f238 into main Oct 17, 2025
9 checks passed
@durran durran deleted the NODE-7019 branch October 17, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants