PYTHON-3256 Obtain AWS credentials for CSFLE in the same way as for MONGODB-AWS #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Aug 30, 2022
| import copy | ||
|
|
||
| try: | ||
| from pymongo_auth_aws.auth import _aws_temp_credentials |
Member
There was a problem hiding this comment.
Could you open a new ticket to make _aws_temp_credentials a public API?
Member
Author
There was a problem hiding this comment.
| return | ||
| if not _HAVE_AUTH_AWS: | ||
| raise RuntimeError( | ||
| "MONGODB-AWS authentication requires pymongo-auth-aws: " |
Member
There was a problem hiding this comment.
"MONGODB-AWS authentication" is not relevant here. Should say "on demand aws credentials require..."
Should we add pymongo-auth-aws to pymongo[encryption] too?
Member
Author
There was a problem hiding this comment.
Opened #452 and updated mongodb/mongo-python-driver#1035
| This is a separate function so it can be overridden in unit tests.""" | ||
| if 'aws' not in kms_providers: | ||
| return | ||
| if len(kms_providers['aws']): |
Member
There was a problem hiding this comment.
If we already provided non-empty aws creds to libmongocrypt is this state even possible to reach?
Member
Author
There was a problem hiding this comment.
This was in preparation for other types of on-demand credentials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-do of #440 after an accidental merge and revert.