Skip to content

PYTHON-3256 Update error message #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2022
Merged

PYTHON-3256 Update error message #452

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
929f6fe
PYTHON-3256 Update error message
blink1073 Aug 31, 2022
8035e0b
update message
blink1073 Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/python/pymongocrypt/mongocrypt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,7 @@ def _ask_for_kms_credentials(kms_providers):
return
if not _HAVE_AUTH_AWS:
raise RuntimeError(
"MONGODB-AWS authentication requires pymongo-auth-aws: "
"On-demand AWS credentials require pymongo-auth-aws: "
"install with: python -m pip install 'pymongo[aws]'"
Copy link
Member

@ShaneHarvey ShaneHarvey Aug 31, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"[aws]" -> "[encryption]"?

Copy link
Member Author

@blink1073 blink1073 Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was asuuming you'd only hit this if using a version of pymongo that didn't include pymongo_aws_auth in the encryption extra.

Copy link
Member

@ShaneHarvey ShaneHarvey Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good point.

)
creds = _aws_temp_credentials()
Expand Down