Skip to content

Conversation

@shubhamhii
Copy link
Contributor

This PR fixes the signbit symbol missing issue.

Below is the issue URL.

https://jira.mongodb.org/browse/CDRIVER-6103

@shubhamhii shubhamhii requested a review from a team as a code owner October 7, 2025 18:22
@shubhamhii shubhamhii requested a review from rcsanchez97 October 7, 2025 18:22
Copy link
Contributor

@rcsanchez97 rcsanchez97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that the Boolean logic is correct? It looks to me like it should rather be && !defined(_AIX), otherwise the logic breaks. For example the way you have implemented the check, if __FreeBSD__ were defined and _AIX were not defined(i.e., because we are compiling on FreeBSD) then the condition would be false && (true || false) || true. This evaluates to an overall value of true, and results in the call to signbit on a platform that doesn't have it (FreeBSD in this case).

@shubhamhii
Copy link
Contributor Author

Can you confirm that the Boolean logic is correct? It looks to me like it should rather be && !defined(_AIX), otherwise the logic breaks. For example the way you have implemented the check, if __FreeBSD__ were defined and _AIX were not defined(i.e., because we are compiling on FreeBSD) then the condition would be false && (true || false) || true. This evaluates to an overall value of true, and results in the call to signbit on a platform that doesn't have it (FreeBSD in this case).

Thanks for pointing it out.
Corrected the logic.

@kevinAlbs kevinAlbs self-requested a review October 7, 2025 20:18
@kevinAlbs kevinAlbs changed the title AIX build failure fix CDRIVER-6103 AIX build failure fix Oct 7, 2025
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @shubhamhii!

@shubhamhii
Copy link
Contributor Author

Thank you for the contribution @shubhamhii!

Thanks a lot for your help.

@rcsanchez97 rcsanchez97 merged commit f837282 into mongodb:master Oct 7, 2025
10 of 12 checks passed
@shubhamhii shubhamhii deleted the CDRIVER-6103 branch October 7, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants