CDRIVER-6134 check overflow #2159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vector-of-bool
approved these changes
Oct 22, 2025
vector-of-bool
requested changes
Oct 22, 2025
| // `inlen` is a string length (excluding trailing NULL). | ||
| // Cyrus-SASL passes an `out` buffer of size `out_max + 1`. Assume `out_max` is the max to be safe. | ||
| if (inlen + 1 >= out_max) { | ||
| if (inlen == UINT_MAX || inlen + 1 >= out_max) { |
There was a problem hiding this comment.
Actually, I recommend using mlib_add() here, since it is not sensitive to the types of its argument, while this relies on UINT_MAX always being the correct value to check.
There was a problem hiding this comment.
Good point. Updated to use mlib_add().
vector-of-bool
approved these changes
Oct 24, 2025
| // `inlen` is a string length (excluding trailing NULL). | ||
| // Cyrus-SASL passes an `out` buffer of size `out_max + 1`. Assume `out_max` is the max to be safe. | ||
| if (inlen + 1 >= out_max) { | ||
| unsigned inlen_1; |
There was a problem hiding this comment.
Need to init = 0 for MSVC quirks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2156 to check for the case where
inlenisUINT_MAXbefore adding one.