Skip to content

Ensure dst_vec is initialized after init_copy() #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

Ensure dst_vec is initialized after init_copy() #2170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/common/src/mlib/vec.th
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,8 @@ fn(init_copy(VecName *dst_vec, VecName const *src_vec)) mlib_noexcept
if (!fn(reserve(&tmp, src_vec->size))) {
// We failed to reserve capacity in the new vector
fn(destroy(&tmp));
// Always leave `dst_vec` in an initialized state.
*dst_vec = (VecName){NULL, 0, 0};
return false;
}
// Copy everything into the destination element-by-element
Expand All @@ -412,6 +414,8 @@ fn(init_copy(VecName *dst_vec, VecName const *src_vec)) mlib_noexcept
if (!VecCopyElement((out_iter), (in_iter))) {
// Failed copying here. Undo everything by destroying the temporary
fn(destroy(&tmp));
// Always leave `dst_vec` in an initialized state.
*dst_vec = (VecName){NULL, 0, 0};
return false;
}
// Update the size of the temporary vec to record that it is holding the new
Expand Down