Skip to content

CSHARP-2456 and CSHARP-2442 JsonWriter NeedsEscaping optimization and StringBuilder capacity increase. #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2024
Merged

CSHARP-2456 and CSHARP-2442 JsonWriter NeedsEscaping optimization and StringBuilder capacity increase. #1290

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ff8038
CSHARP-2456: Use explicit function instead of anonymous.
Oct 15, 2018
2e34708
CSHARP-2442: Increase StringBuilder capacity.
Achilles1515 Nov 27, 2018
dd99d23
CSHARP-2442: Multiply by 2 instead of adding 1 for increased StringBu…
rstam Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/MongoDB.Bson/IO/JsonWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,12 +814,12 @@ protected override void Dispose(bool disposing)
// private methods
private string EscapedString(string value)
{
if (value.All(c => !NeedsEscaping(c)))
if (!NeedsEscaping(value))
{
return value;
}

var sb = new StringBuilder(value.Length);
var sb = new StringBuilder(value.Length * 2);

foreach (char c in value)
{
Expand Down Expand Up @@ -935,6 +935,19 @@ private string GuidToString(BsonBinarySubType subType, byte[] bytes, GuidReprese
}
}

private static bool NeedsEscaping(string text)
{
foreach (var letter in text)
{
if (NeedsEscaping(letter))
{
return true;
}
}

return false;
}

private static bool NeedsEscaping(char c)
{
switch (c)
Expand Down