CSHARP-2187: Flatten CombinedProjectionDefinitions to reduce recursive calls to Render. #1333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fluently building a projection, each call to
IncludeorExcludecreates a newCombinedProjectionDefinition<T>with the projection to that point and the new include/exclude projection. This results in a chain of nested projections. When this chain is rendered,CombinedProjectionDefinition<T>.Renderis called recursively. With a large number of included/excluded fields, this can result in significant callstack depth. Although it is unlikely in common cases to overflow the stack, it is possible as demonstrated by the test case. This issue was resolved by flattening nestedCombinedProjectionDefinition<T>instances.