CSHARP-5436: Optimize special case of Any with constant array and fie… #1585
Conversation
…ld equals parameter in predicate
|
|
||
| public override AstNode VisitExprFilter(AstExprFilter node) | ||
| { | ||
| var optimizedNode = (AstExprFilter)base.VisitExprFilter(node); |
There was a problem hiding this comment.
Decided to visit upfront, for easier handling of nested documents scenario.
There was a problem hiding this comment.
Is it safe to assume base.VisitExprFilter always returns an AstExprFilter? I guess looking at the source code we can convince ourselves that it does.
There was a problem hiding this comment.
Good catch. Even if it always returns VisitExprFilter for now, it's better to double-check.
| mapExpression.In is AstBinaryExpression inBinaryExpression && | ||
| inBinaryExpression.Operator == AstBinaryOperator.Eq && | ||
| TryGetBinaryExpressionArguments(inBinaryExpression, out AstFieldPathExpression fieldPathExpression, out AstVarExpression varExpression) && | ||
| fieldPathExpression.Path.Length > 1 && fieldPathExpression.Path[0] == '$' && fieldPathExpression.Path[1] != '$' && |
There was a problem hiding this comment.
Should we have some more elegant way to check if fieldPath points to the "current" variable?
There was a problem hiding this comment.
Not sure what you mean.
But anything that starts with $$ is not a field so I think that's all we need to check.
|
|
||
| return optimizedNode; | ||
|
|
||
| static bool TryGetBinaryExpressionArguments<T1, T2>(AstBinaryExpression binaryExpression, out T1 arg1, out T2 arg2) |
There was a problem hiding this comment.
Theoretically could be reusable.
There was a problem hiding this comment.
We can wait until there is a need.
|
|
||
| public override AstNode VisitExprFilter(AstExprFilter node) | ||
| { | ||
| var optimizedNode = (AstExprFilter)base.VisitExprFilter(node); |
There was a problem hiding this comment.
Is it safe to assume base.VisitExprFilter always returns an AstExprFilter? I guess looking at the source code we can convince ourselves that it does.
| fieldPathExpression.Path.Length > 1 && fieldPathExpression.Path[0] == '$' && fieldPathExpression.Path[1] != '$' && | ||
| varExpression == mapExpression.As) | ||
| { | ||
| return AstFilter.In(AstFilter.Field(fieldPathExpression.Path.Substring(1)), inputArrayValue); |
There was a problem hiding this comment.
Add a comment just before this line to visualize the simplification being done:
// { $expr : { $anyElementTrue : { $map : { input : <constantArray>, as : "<var>", in : { $eq : ["$<dottedFieldName>", "$$<var>"] } } } } }
// => { "<dottedFieldName>" : { $in : <constantArray> } }
return AstFilter.In(AstFilter.Field(fieldPathExpression.Path.Substring(1)), inputArrayValue);
| mapExpression.In is AstBinaryExpression inBinaryExpression && | ||
| inBinaryExpression.Operator == AstBinaryOperator.Eq && | ||
| TryGetBinaryExpressionArguments(inBinaryExpression, out AstFieldPathExpression fieldPathExpression, out AstVarExpression varExpression) && | ||
| fieldPathExpression.Path.Length > 1 && fieldPathExpression.Path[0] == '$' && fieldPathExpression.Path[1] != '$' && |
There was a problem hiding this comment.
Not sure what you mean.
But anything that starts with $$ is not a field so I think that's all we need to check.
|
|
||
| return optimizedNode; | ||
|
|
||
| static bool TryGetBinaryExpressionArguments<T1, T2>(AstBinaryExpression binaryExpression, out T1 arg1, out T2 arg2) |
There was a problem hiding this comment.
We can wait until there is a need.
|
|
||
| namespace MongoDB.Driver.Tests.Linq.Linq3Implementation.Jira | ||
| { | ||
| public class AnyEqualTests : Linq3IntegrationTest |
There was a problem hiding this comment.
Is this the file name we want for these tests?
2 participants
…ld equals parameter in predicate