CSHARP-3435: FilterDefinition Inject method should use root serializer #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelinowona
approved these changes
May 14, 2025
Contributor
adelinowona
left a comment
adelinowona
left a comment
There was a problem hiding this comment.
LGTM but I left a simple comment
| { | ||
| throw new ExpressionNotSupportedException(expression, because: $"FilterDefinition TDocument type: {filterDefinitionDocumentType} does not match document type {documentSerializer.ValueType} "); | ||
| } | ||
| var serializerRegistry = BsonSerializer.SerializerRegistry; |
Contributor
There was a problem hiding this comment.
nit: no need to store a var for serializerRegistry, we could just have BsonSerializer.SerializerRegistry directly where it is used
Contributor
Author
There was a problem hiding this comment.
I like to decouple as much as possible the SOURCE of the registry from the USE of it.
Intermediate variables are usually a good thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.