Strategy pattern for BsonClassMapSerializer #282
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnickless
changed the title
dnickless
changed the title
dnickless
force-pushed
the
BsonClassMapSerializer_Refactor_to_OO
branch
from
0217ba2 to
5a2f815
Compare
dnickless
force-pushed
the
BsonClassMapSerializer_Refactor_to_OO
branch
from
5a2f815 to
2083538
Compare
…anching and shift towards an OO/composition based code style
…aging static variables inside the generic BsonClassMapSerializer<TClass>.ClassDeserializationStrategy type
dnickless
force-pushed
the
BsonClassMapSerializer_Refactor_to_OO
branch
from
2083538 to
2cea649
Compare
Contributor
Author
|
I just rebased and optimized the suggested refactoring. Also, there now is some performance-relevant change (less repeated usage of reflection) included which - should you wish not to merge the refactoring part - could be applied to the current code base separately. |
Contributor
|
Hi @dnickless, thank you for this architectural improvement suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BsonClassMapSerializer.DeserializeClass(BsonDeserializationContext context)method contained code to handle two basic cases depending on the value of_classMap.HasCreatorMaps: The deserialization using aDictionary<string, object>and the "standard" deserialization. By introducing a strategy pattern I could reduce branching (minor performance gain in theory but potentially wiped out due to additional method calls, I get varying results...) and refactor the code into a more OO kind of layout.