CSHARP-2383: Provide overloads for WriteBytes/ReadBytes methods that … #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allow buffer reuse
…iption. Provided default values for the offset.
Contributor
|
Hi @XiCode, thanks for your contribution. We have plans on updating our codebase to using Span in the near future and that will involve/void such work as this. Thus I'll be closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…allow buffer reuse.
I've created overloads for reading and writing buffers that are larger than the data they hold. With this new api one can limit the size of the used buffer with a parameter. Now it is possible the reuse one large enough buffer and reduce fragmentation of memory.
The overloads in JsonWriter will clone buffers that are too large and reduce them to the given size.