Address C4927 MSVC warnings for array -> document conversions #1480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1470. Per MSVC:
This might be a false-positive.
to_v1(v)
returns av1::array::view
, which uses its user-defined conversion function to convert to av1::document::view
, the parameter type requested by thescoped_bson_view
ctor. I wonder if the use of{}
-initialization without a typename is confusing the compiler into thinking there is another layer of implicit conversion occurring here. Nevertheless, the workaround is trivial (simply making the array -> document conversion explicit).