This repository was archived by the owner on Dec 22, 2021. It is now read-only.
PERL-1009 - Fix datetime rounding issue for blead with uselongdoubles #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at if 64bit not available, use built-in rounding otherwise
|
Rebased and merged. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the datetime issue on blead when
uselongdoublesis enabled. It replaces a direct rounding of the fraction in the epoch parsing code withMath::BigFloatwhen not available.Since the affected code was adjusted to fix the 32bit issues, I ran tests to verify permutations of 32/64 bit,
uselongdoublesenabled and disabled, on blead and on stable.