PHPC-408: Ensure object_to_bson() always creates a BSON document

[jmikola]

https://jira.mongodb.org/browse/PHPC-408

[bjori]

This really wasn't intentional.

I would remove this check from the test, and make a totally new testcase for the exact ticket.

[bjori]

I don't think this is a good idea. Silently serializing objects as empty?
Its a clear data loss at least without any indication of the error.

I would rather see an exception thrown.

[bjori]

This doesn't make a whole lot of sense to me.

php -r '$d = new DateTime("now"); var_dump($d);'                                                                                                                                                                     <<<
object(DateTime)#1 (3) {
  ["date"]=>
  string(26) "2015-09-09 16:13:49.000000"
  ["timezone_type"]=>
  int(3)
  ["timezone"]=>
  string(19) "America/Los_Angeles"
}

Why wouldn't at least the public properties be serialized?

[derickr]

The output is in fact right. It serializes the object's real properties, of which DateTime has none. This is also the output that matches what Hippo does. DateTime only creates those when you make a var_dump() or use the debug handler.... (yes, that is odd).

I don't think however think it's nice to serialize as some random object... hence PHPC-410 makes sense (and #103)

[jmikola]

I don't think this is a good idea. Silently serializing objects as empty? Its a clear data loss at least without any indication of the error. I would rather see an exception thrown.

As @derickr mentioned, #103 is my proposed change for that. I just broke these into separate PRs to address the issue Derick raised in PHPC-408 independently.

[derickr]

I thought you were going to throw an exception in this case?

[jmikola]

https://github.com/mongodb-labs/mongo-php-driver-prototype/pull/103/files#diff-f7d29a680148f52d6601f59ed787f577R712 throws an exception for an unsupported BSON Type, but any other object will ideally get its public properties serialized.