Skip to content

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Oct 10, 2019

https://jira.mongodb.org/browse/PHPC-1418

@jmikola: looking at the diff that introduced PHP 7.3, I see that PHP 7.0 was removed. However, Evergreen build stages covering PHP 7.0 still complete successfully, so I'm not quite sure what's going on here. Do you know what's going on here, or where I could check to find out?

@alcaeus alcaeus requested a review from jmikola October 10, 2019 12:34
@alcaeus alcaeus self-assigned this Oct 10, 2019
@jmikola
Copy link
Member

jmikola commented Oct 15, 2019

However, Evergreen build stages covering PHP 7.0 still complete successfully, so I'm not quite sure what's going on here. Do you know what's going on here, or where I could check to find out?

Not sure myself, but I'd suggest either asking @kryptonite303, following up on BUILD-8750, or reaching out in #evergreen-users in Slack. It's possible the Evergreen team was just going by PHP: Supported Versions, but that doesn't explain why they'd have left 5.5 and 5.6 in place.

@jmikola
Copy link
Member

jmikola commented Oct 15, 2019

Also, note that the Evergreen builds in this PR are all using PHP 5.6 and 7.3, so it doesn't look like they'd have caught a removal of 7.0; however, 7.0 builds in https://evergreen.mongodb.com/waterfall/mongo-php-driver are still OK from what I can tell.

Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual changes LGTM. I suppose you can follow up re: 7.0 outside of this PR.

alcaeus added a commit that referenced this pull request Oct 17, 2019
@alcaeus alcaeus merged commit acc5942 into mongodb:master Oct 17, 2019
@alcaeus alcaeus deleted the phpc-1418 branch October 17, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants