PHPC-1002: Test against multiple libmongoc versions on evergreen #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Oct 21, 2019
CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
I suppose this is an argument for not simply adding r1.16 to the axis, but rather replacing the previous entry for r1.15.
There was a problem hiding this comment.
Yes and no. Let's say 1.16 is released but we don't require it yet (for whatever reason). In this case, it would make sense adding r1.16 to the axis instead of replacing r1.15. Once we require 1.16 or newer, we can drop r1.15 from the axis.
|
@jmikola: made the changes you suggested. I've also added a replicaset and sharded build for more resiliency. New patch build: https://evergreen.mongodb.com/version/5dafee1c1e2d170cf567f51c. |
jmikola
approved these changes
Oct 23, 2019
alcaeus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1002
This PR adds tests against the current stable branch (r.1.15) and upcoming minor version (master, 1.16-dev) to evergreen. This helps us ensure that builds work against the upcoming libmongoc version. For a patch build, see https://evergreen.mongodb.com/version/5dada5af1e2d17070614e379.