PHPC-2627: Use appropriate return type for zend_object_iterator_funcs.valid #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Oct 14, 2025
Member
GromNaN
left a comment
GromNaN
left a comment
There was a problem hiding this comment.
LGTM.
Is it a bugfix to backport to 2.1 or even 1.21?
Member
Author
|
No need to backport. This is just addressing a build warning that has been present for some time already. |
GromNaN
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2627
See: https://github.com/php/php-src/blob/571bded46ece6922f0bef0d135986786e9b49029/UPGRADING.INTERNALS#L29-L31