PHPC-349: Fixes and code cleanup #568
Conversation
php_phongo_structs.h
Outdated
| mongoc_client_t *client; | ||
| char *command_name; | ||
| uint32_t server_id; | ||
| int server_id; |
There was a problem hiding this comment.
This is curious. For some of the event_ts we use int, and sometimes uint32_t for this. One of them is right...
There was a problem hiding this comment.
The server and cursor structs use int. I'm not sure where uint32_t came from.
I believe this is only a diff because I re-ordered the struct definitions to be alphabetical; however, it'd be a good idea to make them consistent.
There was a problem hiding this comment.
Can you fix this one in your PR so I can merge it cleanly then?
| #ifndef PHONGO_MONITORING_H | ||
| #define PHONGO_MONITORING_H | ||
|
|
||
| #include <php.h> |
There was a problem hiding this comment.
php.h is where PHP_FUNCTION() is defined. This wasn't an error before as you generally have php.h included before this file, but I considered it good practice to have headers include their dependencies.
php_phongo_structs.h
Outdated
| mongoc_client_t *client; | ||
| char *command_name; | ||
| uint32_t server_id; | ||
| int server_id; |
There was a problem hiding this comment.
Can you fix this one in your PR so I can merge it cleanly then?
|
These last two commits made Travis unhappy... |
2 participants
Related to: #466