PYTHON-3396 Support the Azure VM-assigned Managed Identity for Automatic KMS Credentials #1105
Conversation
…tic KMS Credentials
| curl -O https://s3.amazonaws.com/mciuploads/libmongocrypt/all/master/latest/libmongocrypt-all.tar.gz | ||
| mkdir libmongocrypt-all && tar xzf libmongocrypt-all.tar.gz -C libmongocrypt-all | ||
| $PYTHON -m pip install '.' | ||
| PYMONGOCRYPT_LIB=$(pwd)/libmongocrypt-all/debian10/nocrypto/lib/libmongocrypt.so TEST_FLE_AZURE_AUTO=1 $PYTHON test/test_on_demand_csfle.py |
There was a problem hiding this comment.
This file looks almost identical to the gcp one. Can we reuse that file rather than introducing another? In fact, I believe we could even reuse run-tests.sh with some minor changes to the TEST_ARGS logic.
There was a problem hiding this comment.
Any thoughts about the second suggestion to use run-tests.sh? That file already knows how to download and setup libmongocrypt.
.evergreen/config.yml
Outdated
| export AZUREKMS_VMNAME=${AZUREKMS_VMNAME} | ||
| export AZUREKMS_PRIVATEKEYPATH=/tmp/testazurekms_privatekey | ||
| AZUREKMS_CMD="MONGODB_URI='mongodb://localhost:27017' KEY_NAME='${testazurekms_keyname}' KEY_VAULT_ENDPOINT='${testazurekms_keyvaultendpoint}' SUCCESS=true TEST_FLE_AZURE_AUTO=1 ./.evergreen/run-mongodb-fle-auto.sh" \ | ||
| AZUREKMS_CMD="MONGODB_URI='mongodb://localhost:27017' KEY_NAME='${testazurekms_keyname}' KEY_VAULT_ENDPOINT='${testazurekms_keyvaultendpoint}' SUCCESS=true TEST_ENCRYPTION=1 TEST_FLE_AZURE_AUTO=1 ./.evergreen/run-tests.sh" \ |
There was a problem hiding this comment.
You might need to pass the right LIBMONGOCRYPT_URL for the remote azure host here.
.evergreen/config.yml
Outdated
| export GCPKMS_ZONE=${GCPKMS_ZONE} | ||
| export GCPKMS_INSTANCENAME=${GCPKMS_INSTANCENAME} | ||
| GCPKMS_CMD="SUCCESS=true TEST_FLE_GCP_AUTO=1 ./.evergreen/run-mongodb-fle-auto.sh mongodb://localhost:27017" $DRIVERS_TOOLS/.evergreen/csfle/gcpkms/run-command.sh | ||
| GCPKMS_CMD="SUCCESS=true TEST_ENCRYPTION=1 TEST_FLE_GCP_AUTO=1 ./.evergreen/run-tests.sh" $DRIVERS_TOOLS/.evergreen/csfle/gcpkms/run-command.sh |
There was a problem hiding this comment.
You might need to pass the right LIBMONGOCRYPT_URL for the remote gcp host here.
|
Apparently the |
ShaneHarvey
left a comment
ShaneHarvey
left a comment
There was a problem hiding this comment.
In this case, the final line break and any trailing empty lines are excluded from the scalar’s content
I don't understand how the final newline could change the behavior here but LGTM.
2 participants
Companion to mongodb/libmongocrypt#484
Also fixes a bug in PYTHON-3367 where we we were running the test file but not actually running the GCP tests.