-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-3727 Use tox for unit tests and switch to pytest #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think more has to be done to make us pytest-compatible, lots of the tests are getting skipped that shouldn't be. Note that the I believe the equivalent of the setup and teardown functions will need to be done in a def pymongo_test_fixture(scope='session', autouse=True):
# do setup stuff
yield
# do teardown stuff |
Latest commit should address this, I've added a session-level autouse fixture to perform the
Latest commit should address this, I've added a session-level autouse fixture to perform the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
tox.ini
Outdated
deps = | ||
{[testenv:test]deps} | ||
pymongocrypt>=1.6.0,<2.0.0 | ||
pymongo-auth-aws<2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to refer to extras here so we don't need to duplicate the dependencies? like .[encryption]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that should work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice LGTM!
No description provided.