PYTHON-3893 Add BSON Binary Data subtype Sensitive #1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
requested review from
blink1073 and
sleepyStick
and removed request for
a team
blink1073
requested changes
Aug 1, 2023
bson/binary.py
Outdated
| SENSITIVE_SUBTYPE = 8 | ||
| """BSON binary subtype for sensitive data. | ||
| .. versionadded:: 7.0 |
Member
There was a problem hiding this comment.
This should be 4.5 (the pymongo version).
ShaneHarvey
reviewed
Aug 1, 2023
| """ | ||
|
|
||
| SENSITIVE_SUBTYPE = 8 | ||
| """BSON binary subtype for sensitive data. |
Member
There was a problem hiding this comment.
Are users ever expected to use this?
Member
There was a problem hiding this comment.
The spec doesn't mention it, but other drivers expose these constants, e.g. https://github.com/mongodb/mongo-go-driver/blob/4acd55139b846e6bfdfe316770a5b1b646d5ff96/bson/types.go#L47.
ShaneHarvey
approved these changes
Aug 2, 2023
blink1073
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.