PYTHON-3598 Add Command(Succeeded|Failed)Event.database_name property #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… databaseName on events (if commandStartedEvent did so as well)
Jibola
changed the title
Jibola
changed the title
ShaneHarvey
requested changes
Sep 13, 2023
ShaneHarvey
requested changes
Sep 19, 2023
Member
|
Since this is a public api change could you add a mention in the changelog? |
ShaneHarvey
requested changes
Oct 2, 2023
ShaneHarvey
approved these changes
Oct 4, 2023
Member
ShaneHarvey
left a comment
ShaneHarvey
left a comment
There was a problem hiding this comment.
LGTM, one last thing, when you merge could you update the title/commit message to describe the api change too, like:
PYTHON-3598 Add Command(Succeeded|Failed)Event.database_name property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.