PYTHON-3983 Clean up handling of PYTHON_BINARY #1382
Conversation
|
|
||
| # Get the drivers secrets. Use an existing secrets file first. | ||
| if [ ! -f "./secrets-export.sh" ]; then | ||
| bash .evergreen/tox.sh -m aws-secrets -- drivers/oidc |
There was a problem hiding this comment.
What's the rationale behind directly calling setup_secrets.sh instead of using tox?
There was a problem hiding this comment.
Our tox env replicates the env requirements in DRIVERS_TOOLS, I think we should migrate away from it.
There was a problem hiding this comment.
If we migrate away from the tox env, what process do we envision for running these tests locally?
There was a problem hiding this comment.
By running the script in DET to get the secrets file, which would only have to be done infrequently.
There was a problem hiding this comment.
Good point! Can we add that step to the local testing documentation?
There was a problem hiding this comment.
|
In the past we discovered that using venv was problematic on some platforms. Please run the entire test suite to make sure that's no longer the case. |
Good call out, so far macos does not work yet with this approach. |
|
MacOS 64 was the only newly failing platform, will investigate. |
…cleanup-python-binary-handling
…cleanup-python-binary-handling
3 participants
No description provided.