Skip to content

PYTHON-3991 Fix MockupDB tests when run through tox #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2023
Merged

PYTHON-3991 Fix MockupDB tests when run through tox #1388

merged 1 commit into from
Oct 12, 2023

Conversation

@ShaneHarvey
Copy link
Member

@ShaneHarvey ShaneHarvey commented Oct 12, 2023

@ShaneHarvey ShaneHarvey requested a review from a team as a code owner October 12, 2023 18:46
@ShaneHarvey ShaneHarvey requested review from NoahStapp and blink1073 and removed request for a team October 12, 2023 18:46
@blink1073
Copy link
Member

blink1073 commented Oct 12, 2023

I think the fix is to use python -m pytest in the test task.

NoahStapp
NoahStapp approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good find!

@NoahStapp
Copy link
Contributor

NoahStapp commented Oct 12, 2023

I think the fix is to use python -m pytest in the test task.

The MockupDB task needs the test extra to have pytest be present in the environment.

@ShaneHarvey ShaneHarvey merged commit c0f463f into mongodb:master Oct 12, 2023
@ShaneHarvey ShaneHarvey deleted the PYTHON-3991 branch October 12, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blink1073 blink1073 blink1073 approved these changes

@NoahStapp NoahStapp NoahStapp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShaneHarvey @blink1073 @NoahStapp