Skip to content

PYTHON-2605: Improve mongodb+srv:// error message when dnspython is not installed #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2021
Merged

PYTHON-2605: Improve mongodb+srv:// error message when dnspython is not installed #602

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1334e5f
Generate error message for installation when ConfigurationError is ra…
Kn99HN Apr 23, 2021
7270b4c
Replace os with sys and format error message
Kn99HN Apr 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pymongo/uri_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"""Tools to parse and validate a MongoDB URI."""
import re
import warnings
import sys

from urllib.parse import unquote_plus

Expand Down Expand Up @@ -416,8 +417,12 @@ def parse_uri(uri, default_port=DEFAULT_PORT, validate=True, warn=False,
scheme_free = uri[SCHEME_LEN:]
elif uri.startswith(SRV_SCHEME):
if not _HAVE_DNSPYTHON:
raise ConfigurationError('The "dnspython" module must be '
'installed to use mongodb+srv:// URIs')
python_path = sys.executable or "python"
raise ConfigurationError(
'The "dnspython" module must be '
'installed to use mongodb+srv:// URIs. '
'To fix this error install pymongo with the srv extra:\n '
'%s -m pip install "pymongo[srv]"' % (python_path))
is_srv = True
scheme_free = uri[SRV_SCHEME_LEN:]
else:
Expand Down