PYTHON-2533 Add support for sample_rate and filter in set_profiling_level #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantmital
approved these changes
Apr 28, 2021
Contributor
prashantmital
left a comment
prashantmital
left a comment
There was a problem hiding this comment.
Changes LGTM but given that there is no driver spec for this command, is this something we want to remove in PyMongo 4.0? If so, can we:
- Change the base branch to merge this change to
v3.12 - Add a deprecation warning to this helper either here or open a ticket to deprecate it in 3.12
- Open a ticket to remove the profiling helper in PyMongo 4.0
Member
Author
|
I opened https://jira.mongodb.org/browse/PYTHON-2662 to investigate the deprecation idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the docs here: https://docs.mongodb.com/manual/reference/command/profile/
sampleRatewas added in 3.6.filterwas added in 4.4.2.Filter is a bit odd in that it accepts a query document OR the string "unset" which resets and disables the filter. For this reason I decided not to perform client-side type validation on the filter parameter.
I also decided not to add
**kwargs. Adding**kwargslet's users do strange things like pass arbitrary command arguments (txnNumber, lsid, writeConcern, etc..) and makes the code more confusing since we then need to define (or at least think about) precedence in cases like this:db.set_profiling_level(ALL, slow_ms=50, slowms=55)