PYTHON-2635 Unpin on abortTransaction #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note the one test failure is unrelated to this change and is already a known (rare) issue that appears to be back from the grave: https://jira.mongodb.org/browse/PYTHON-2279 |
prashantmital
approved these changes
Apr 28, 2021
test/test_transactions.py
Outdated
| TestTransactionsConvenientAPI.TEST_PATH).create_tests() | ||
|
|
||
|
|
||
| UNIFIED_TEST_PATH = os.path.join( |
ShaneHarvey
added a commit
that referenced
this pull request
Apr 28, 2021
Add unified test runner for transactions. (cherry picked from commit 61c6876)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the following related tickets:
Note we already unpin on any retryable or transient errors so the only thing left to do in pymongo is to unpin before returning from the abort_transaction() method.
This change also introduces
unified/spec tests for transactions.