Skip to content

PYTHON-1834 Use a code formatter #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 9, 2022
Merged

PYTHON-1834 Use a code formatter #852

merged 7 commits into from
Feb 9, 2022

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Feb 8, 2022 •
edited
Loading

Ran black --line-length 100 .and isort --profile black . on the codebase.

black --version
black, 22.1.0 (compiled: yes)

ShaneHarvey
ShaneHarvey requested changes Feb 8, 2022
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run black/isort again now that you've manually fixed the mypy issues.

@ShaneHarvey
Copy link
Member

ShaneHarvey commented Feb 8, 2022

Also let's use isort --profile black . to fix the black + isort conflicts.

@blink1073
Copy link
Member Author

blink1073 commented Feb 8, 2022

Also let's use isort --profile black . to fix the black + isort conflicts.

Done, updated top level comment

@blink1073
Copy link
Member Author

blink1073 commented Feb 8, 2022

Note to self, use args: [--profile=black] in the pre-commit file.

@blink1073 blink1073 requested a review from ShaneHarvey February 8, 2022 23:36
@ShaneHarvey
Copy link
Member

ShaneHarvey commented Feb 9, 2022

Note the one test failure was a flake and can be ignored.

@blink1073 blink1073 merged commit 5578999 into mongodb:master Feb 9, 2022
@blink1073 blink1073 deleted the PYTHON-1834 branch February 9, 2022 12:44
juliusgeo pushed a commit to juliusgeo/mongo-python-driver that referenced this pull request Apr 5, 2022
@blink1073 @juliusgeo
PYTHON-1834 Use a code formatter (mongodb#852)
f9dde06
juliusgeo pushed a commit to juliusgeo/mongo-python-driver that referenced this pull request Apr 7, 2022
@blink1073 @juliusgeo
PYTHON-1834 Use a code formatter (mongodb#852)
b7d8988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

@juliusgeo juliusgeo Awaiting requested review from juliusgeo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blink1073 @ShaneHarvey