PYTHON-3189 Change Stream event document missing to field for rename events #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Apr 12, 2022
pymongo/collection.py
Outdated
| self, | ||
| new_name: str, | ||
| new_name: Optional[str] = None, | ||
| to: Optional[str] = None, |
Member
There was a problem hiding this comment.
I assume you only added "to" so that the new test would pass. Since we already have "new_name" we don't need a "to" parameter. Let's remove it and instead change the unified test runner to translate the "to" parameter to "new_name". We already do this kind of parameter translation here:
mongo-python-driver/test/utils.py
Line 1021 in 5578999
ShaneHarvey
approved these changes
May 6, 2022
Member
Author
|
Both failures are transient (centos URL and |
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.