PYTHON-3038 The doc should clarify that the resulting documents that are produced with upserts are constructed from both the filter and the update params #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
approved these changes
Apr 28, 2022
Member
blink1073
left a comment
blink1073
left a comment
There was a problem hiding this comment.
LGTM, looks like you need to run pre-commit locally and pull from master to pick up the mypy version pins.
ShaneHarvey
requested changes
Apr 28, 2022
pymongo/collection.py
Outdated
| If ``upsert=True`` and no documents match the filter, create a | ||
| new document based on the filter criteria and update modifications. | ||
| >>> result = db.test.update_one({'x': -1*2**32}, {'$inc': {'x': 3}}, upsert=True) |
Member
There was a problem hiding this comment.
What do you think about using update_one({'x': -10}, ... instead (for clarity)?
Contributor
Author
There was a problem hiding this comment.
That makes sense to me. Fixed.
ShaneHarvey
requested changes
Apr 29, 2022
pymongo/collection.py
Outdated
| >>> result.upserted_id | ||
| ObjectId('626a678eeaa80587d4bb3fb7') | ||
| >>> for doc in db.test.find(): | ||
| ... print(doc) |
Member
There was a problem hiding this comment.
I just noticed this would make more sense as a find_one:
>>> db.test.find_one(result.upserted_id)
{'_id': ObjectId('626a678eeaa80587d4bb3fb7'), 'x': -7}
ShaneHarvey
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.