PYTHON-3250 Speed up majority writes in test suite #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusgeo
approved these changes
May 3, 2022
Contributor
juliusgeo
left a comment
juliusgeo
left a comment
There was a problem hiding this comment.
LGTM! Impressive speed-up!
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shaves off anywhere from 1 minute to 16 minutes from the test suite on macos depending of the server version and topology: https://spruce.mongodb.com/task/mongo_python_driver_test_macos__platform~macos_1014_auth~auth_ssl~ssl_test_4.2_replica_set_patch_05b55e88dfa1636511eeeac56d4a75593a76fbeb_6270a5ab5623434c42b90339_22_05_03_03_46_53/tests?execution=0&sortBy=STATUS&sortDir=ASC
On "macOS 10.14 Auth SSL" alone this change saves 67 minutes of execution time (Time Spent 3h 32m vs 4h 25m).