PYTHON-3245 Support explicit queryable encryption #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
commented
Jun 3, 2022
.evergreen/run-tests.sh
Outdated
|
|
||
| # TODO: Test with 'pip install pymongocrypt' | ||
| git clone --branch master https://github.com/mongodb/libmongocrypt.git libmongocrypt_git | ||
| git clone --branch PYTHON-3285 https://github.com/ShaneHarvey/libmongocrypt.git libmongocrypt_git |
Member
Author
There was a problem hiding this comment.
This needs to be removed once mongodb/libmongocrypt#358 is merged.
| kms_tls_options: Optional[Mapping[str, Any]] = None, | ||
| crypt_shared_lib_path: Optional[str] = None, | ||
| crypt_shared_lib_required: bool = False, | ||
| bypass_query_analysis: bool = False, |
Member
Author
There was a problem hiding this comment.
This will conflict with Julius' auto encryption PR but it was required for the tests.
| SPEC_PATH = os.path.join(BASE, "spec") | ||
|
|
||
| OPTS = CodecOptions(uuid_representation=STANDARD) | ||
| OPTS = CodecOptions() |
Member
Author
There was a problem hiding this comment.
uuid_representation=STANDARD is no longer needed now that we decode uuid's to Binary by default.
| with self.assertRaisesRegex(EncryptionError, "IP address mismatch|wronghost"): | ||
| with self.assertRaisesRegex( | ||
| EncryptionError, "IP address mismatch|wronghost|IPAddressMismatch" | ||
| ): |
Member
Author
There was a problem hiding this comment.
IPAddressMismatch is included in the error when pyopenssl is installed.
blink1073
approved these changes
Jun 3, 2022
|
|
||
| class TestEncryptedBulkWrite(BulkTestBase, EncryptionIntegrationTest): | ||
| def test_upsert_uuid_standard_encrypte(self): | ||
| def test_upsert_uuid_standard_encrypt(self): |
blink1073
approved these changes
Jun 3, 2022
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHON-3245 Implement explicit queryable encryption.
Depends on mongodb/libmongocrypt#358
Implements the prose test here: https://github.com/mongodb/specifications/tree/d4c9432c4b4425fd3dcc0dad0f65d954e7e6e1e4/source/client-side-encryption/tests#explicit-encryption