Merge pull request #684 from estolfo/RUBY-1016-query-op

RUBY-1016 Don't check the 'ok' field in query operation validation

Author: estolfo

lib/mongo/operation/read/query.rb

@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+require 'mongo/operation/read/query/result'
+
 module Mongo
   module Operation
     module Read

lib/mongo/operation/read/query/result.rb

@@ -0,0 +1,40 @@
+# Copyright (C) 2014-2015 MongoDB, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+module Mongo
+  module Operation
+    module Read
+      class Query
+
+        # Defines custom behaviour of results for a query.
+        #
+        # @since 2.1.0
+        class Result < Operation::Result
+
+          # Determine if the query was a success.
+          #
+          # @example Was the query successful?
+          #   result.successful?
+          #
+          # @return [ true, false ] If the query was successful.
+          #
+          # @since 2.0.0
+          def successful?
+            !query_failure? && parser.message.empty?
+          end
+        end
+      end
+    end
+  end
+end

spec/mongo/operation/read/query_spec.rb

@@ -82,6 +82,25 @@
         op.execute(primary_context)
       end
     end
+
+    context "when the document contains an 'ok' field" do
+
+      before do
+        authorized_collection.insert_one(ok: false)
+      end
+
+      after do
+        authorized_collection.delete_many
+      end
+
+      let(:context) do
+        authorized_client.cluster.next_primary.context
+      end
+
+      it 'does not raise an exception' do
+        expect(op.execute(context)).to be_a(Mongo::Operation::Read::Query::Result)
+      end
+    end
   end
 end