Enable trailing whitespace rule in comments #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroadst
approved these changes
Apr 9, 2019
Member
mbroadst
left a comment
mbroadst
left a comment
There was a problem hiding this comment.
LGTM, but can we wait to merge until Swift 5 PR is merged?
Contributor
Author
|
my thought was that we should do this first so the swift 5 support commit is less polluted with all those whitespace changes. I thought it would be a clean rebase since no lines are added/deleted, but if it isn't then we can wait |
patrickfreed
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So apparently you have to tell SwiftLint that you want this rule on for comments....