SWIFT-17: add evergreen linux support #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
patrickfreed
left a comment
patrickfreed
left a comment
There was a problem hiding this comment.
Looks good, just a couple little things and a question. I haven't delved too deeply into an evergreen configuration during my time at mongodb so far, so I can't really comment on the changes there too much.
mbroadst
force-pushed
the
SWIFT-17/evergreen-support
branch
from
66c1354 to
c23c99c
Compare
Member
Author
|
@kmahar https://jira.mongodb.org/browse/SWIFT-399 to track macos builds on EVG |
kmahar
reviewed
Apr 17, 2019
Contributor
kmahar
left a comment
kmahar
left a comment
There was a problem hiding this comment.
one character to delete, lgtm otherwise
| mongoc_uri_destroy(uri) | ||
| } | ||
|
|
||
| guard let hosts = mongoc_uri_get_hosts(uri)! else { |
Contributor
There was a problem hiding this comment.
I think you need to remove the ! here?
- update evergreen config
- install swift using swiftenv
- add support for skipping tests by topology
- add `find-cmake.sh` script
- use patrick's new numeric helpers to avoid topology issues
- ensure all tests of a commands response use `doubleValue` for `ok`
- skip command monitoring tests on sharded topologies
- reduce to a single mongos if multiple are provided
- add 4.2 and 5.0 variants
- disable macos tests until we can figure out how install without
root permissions
mbroadst
force-pushed
the
SWIFT-17/evergreen-support
branch
from
c23c99c to
362f30b
Compare
kmahar
approved these changes
Apr 17, 2019
patrickfreed
approved these changes
Apr 17, 2019
Contributor
patrickfreed
left a comment
patrickfreed
left a comment
There was a problem hiding this comment.
great job getting this working. didn't think we'd have evergreen for a while 🍾
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find-cmake.shscriptdoubleValueforokroot permissions