SWIFT-178 Conform various options/result types to Decodable #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
commented
May 15, 2019
| let decoder = BSONDecoder() | ||
| var insertedIds = result?.insertedIds | ||
|
|
||
| var bulkWriteErrors: [BulkWriteError]? |
Contributor
Author
There was a problem hiding this comment.
When using fail points, sometimes empty (but non-nil) writeErrors and writeConcernErrors arrays are returned for parsing. The way this function was written assumed that wasn't possible and has been rewritten to accommodate those cases.
kmahar
reviewed
May 15, 2019
Contributor
kmahar
left a comment
kmahar
left a comment
There was a problem hiding this comment.
looks good to me, just one thing to check re: docs
| /// Map of the index of the operation to the id of the upserted document. | ||
| public let upsertedIds: [Int: BSONValue] | ||
|
|
||
| private enum CodingKeys: CodingKey { |
Contributor
There was a problem hiding this comment.
it always annoys me that the synthesized code is all or none and you can't use the synthesized coding keys if you use a custom init(from:) implementation...
kmahar
approved these changes
May 16, 2019
mbroadst
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of reviews that make up SWIFT-178
This PR adds
Decodableconformance to options and result types that will eventually be decoded from JSON spec test files. It also improves the error parser to be more flexible when decoding from server replies.