Fix index test failing on server latest #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
commented
May 21, 2019
| * - Example: For an index of name: 1, age: -1, the generated name would be "name_1_age_-1". | ||
| */ | ||
| public let name: String? | ||
| public var name: String? |
Contributor
Author
There was a problem hiding this comment.
this and indexVersion became mutable for the sake of the test. I considered updating all of them but I think that ticket will make it into our next release anyway
kmahar
commented
May 21, 2019
| expect(indexes.next()).to(beNil()) | ||
| } | ||
|
|
||
| func testIndexOptions() throws { |
Contributor
Author
There was a problem hiding this comment.
this is the only index test that actually changed.
| } | ||
| } | ||
|
|
||
| extension IndexOptions: Equatable { |
patrickfreed
approved these changes
May 22, 2019
mbroadst
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as of SERVER-10075 server will error if you create an index using
expireAfterSecondson more than one key. we had a test that was just trying all the index options at once and creating a multi-key index so it started failing on MacOS which I guess bumped latest in the last few days.in this PR I:
IndexOptionsthat can be compared against the original optionsevg patch confirming this fixes it here