Swift-311 Make ReadPrefrerence getters return non-optionals #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncarbon
force-pushed
the
SWIFT-311/Make-ReadPreference-getters-return-non-optionals
branch
from
35ad487 to
e6fa19b
Compare
kmahar
approved these changes
May 30, 2019
patrickfreed
approved these changes
May 31, 2019
Contributor
patrickfreed
left a comment
patrickfreed
left a comment
There was a problem hiding this comment.
LGTM. just make sure the commit message has "SWIFT-311" instead of "Swift 311" so the githook bot picks it up.
ncarbon
changed the title
ncarbon
deleted the
SWIFT-311/Make-ReadPreference-getters-return-non-optionals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadPreference getters in MongoClient, MongoCollection, and MongoDatabase should return non-optionals since their values will never be nil.