SWIFT-632 Drop Swift 4.2 support #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
commented
Oct 8, 2019
| /// API methods that expect a location for a string. **You must only call this method on Data instances with | ||
| /// count > 0 so that the base address will exist.** | ||
| /// Based on https://mjtsai.com/blog/2019/03/27/swift-5-released/ | ||
| fileprivate mutating func withUnsafeMutableCStringPointer<T>(body: (UnsafeMutablePointer<CChar>) throws -> T) |
Contributor
Author
There was a problem hiding this comment.
the old way we were doing this was deprecated
| /// methods that expect the location of an uint8_t. The pointer provided to `body` will be null if the `Data` has | ||
| /// count == 0. | ||
| /// Based on https://mjtsai.com/blog/2019/03/27/swift-5-released/ | ||
| fileprivate func withUnsafeBytePointer<T>(body: (UnsafePointer<UInt8>?) throws -> T) rethrows -> T { |
Contributor
Author
There was a problem hiding this comment.
the old way we were doing this was deprecated
patrickfreed
approved these changes
Oct 9, 2019
mbroadst
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops support for Swift 4.2 and fixes various deprecation warnings that surfaced now that we are no longer using the Swift 5 compiler in 4.2 compatibility mode.