SWIFT-587 Retryable Reads #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
reviewed
Oct 25, 2019
Contributor
kmahar
left a comment
kmahar
left a comment
There was a problem hiding this comment.
basically LGTM, couple small things
| func testRetryableReads() throws { | ||
| let skippedTestKeywords = [ | ||
| "findOne", | ||
| "changeStream", // TODO: SWIFT-648: Unskip this test |
Contributor
There was a problem hiding this comment.
so does libmongoc skip this test or how did they not catch this before?
Contributor
Author
There was a problem hiding this comment.
they run the test and apparently it passes. From talking with Kevin, it seems that maybe they're just not verifying all the results.
|
|
||
| func testRetryableReads() throws { | ||
| let skippedTestKeywords = [ | ||
| "findOne", |
Contributor
There was a problem hiding this comment.
I recently opened SWIFT-643 about adding a findOne method, add a TODO here?
kmahar
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the
retryReadsoption onClientOptionsto the public API and introduces the retryable reads test runner. It also updates much of our general spec test runner to work with crud v2 test files. As part of that, the retryable writes runner was separated into its own thing.