SWIFT-639 Update Vapor example #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
force-pushed
the
vapor-4-example
branch
from
c42c1d3 to
3d11e3a
Compare
kmahar
commented
Feb 20, 2020
Examples/VaporExample/Package.swift
Outdated
| let package = Package( | ||
| name: "VaporExample", | ||
| platforms: [ | ||
| .macOS(.v10_14) |
Contributor
Author
There was a problem hiding this comment.
requirement of Vapor 4
Contributor
There was a problem hiding this comment.
Will this go away once it gets out of beta?
Contributor
Author
There was a problem hiding this comment.
actually, they are planning to drop 10.14 at some point before the release to use SwiftCrypto, so we'll probably have to update this to 10.15 once that happens.
kmahar
force-pushed
the
vapor-4-example
branch
from
3b04528 to
9e18aa1
Compare
kmahar
added a commit
that referenced
this pull request
Feb 21, 2020
kmahar
added a commit
that referenced
this pull request
Feb 26, 2020
kmahar
added a commit
that referenced
this pull request
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting up a draft PR. We probably don't want to merge this for a while because:
@testableimporting in order to use theallmethod onMongoCursorsyncClosemethod toMongoClientas proposed in SWIFT-717 we'll want to use that here