SWIFT-717 Add syncClose method to MongoClient #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
approved these changes
Feb 13, 2020
Contributor
kmahar
left a comment
kmahar
left a comment
There was a problem hiding this comment.
Code changes look good to me, and the name change sounds like a good idea too. I don't need to re-review after you rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIFT-717
This PR adds a
syncClosemethod toMongoClient. Right now, it simply ignores any errors encountered while shutting down the thread pool, but once we add logger support, we can log these errors instead. This is the approach vapor takes.One remaining question I have is whether we want to rename
closeandsyncClosetoshutdownandsyncShutdown/shutdownSyncto more closely match vapor's naming.