SWIFT-314 Use BSONDecoder to decode isMaster responses in SDAM monitoring #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
changed the title
patrickfreed
commented
Feb 12, 2020
| // we have to copy because libmongoc owns the pointer. | ||
| let isMaster = Document(copying: mongoc_server_description_ismaster(description)) | ||
|
|
||
| self.lastWriteDate = isMaster["lasWrite"]?.documentValue?["lastWriteDate"]?.dateValue |
Contributor
Author
There was a problem hiding this comment.
"lasWrite"
whoops
Contributor
There was a problem hiding this comment.
compelling argument for using Codable 🙂
kmahar
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIFT-314
This PR updates the
ServerDescriptioninitializer to rely onBSONDecoderto decode ismaster responses instead of directly accessing the command response document.This ticket originally sought to add graceful error handling to SDAM monitoring event construction, but without access to a logger, there really isn't anything more we can do right now. To that end, I added a number of TODO comments indicating that, once we add support for a logger, we can log when encountering errors.