SWIFT-718 Add a toArray method to async cursor and change stream #406
Conversation
Sources/MongoSwift/MongoCursor.swift
Outdated
| */ | ||
| internal func all() -> EventLoopFuture<[T]> { | ||
| public func toArray() -> EventLoopFuture<[T]> { | ||
| guard self.isAlive else { |
There was a problem hiding this comment.
without this, we would never error even if you call this on a closed cursor and would always return an empty array, because self.cached.clear() would just return nil if the cursor is closed.
There was a problem hiding this comment.
Good catch. One thing to note is that calls to isAlive and cached.clear should probably both only occur while the cursor lock is held, which is making me think we may have to move the cache logic into the internal cursor after all.
There was a problem hiding this comment.
I've moved the caching logic into the common cursor type, and added a static property on MongocCursorWrapper as we discussed to indicate whether we need to cache the first document or not
| // iterating a dead cursor should error | ||
| expect(try cursor.next().wait()).to(throwError()) | ||
|
|
||
| // iterating after calling all should error. |
There was a problem hiding this comment.
this was moved down into the toArray test below
This adds
toArrayto asyncMongoCursorand asyncChangeStream.