SWIFT-639 Update Perfect example #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dependencies: [ | ||
| .package(url: "https://github.com/PerfectlySoft/Perfect-HTTPServer.git", from: "3.0.0"), | ||
| .package(url: "https://github.com/mongodb/mongo-swift-driver", .upToNextMajor(from: "0.1.0")), | ||
| .package(url: "https://github.com/mongodb/mongo-swift-driver", .branch("master")), |
Contributor
There was a problem hiding this comment.
before merging this, we should update this version string to be upToNextMajor(from: "1.0"). Alternatively, before we merge the 1.0 branch into master we can just update it then.
Contributor
There was a problem hiding this comment.
I guess we already have SWIFT-537 for updating the versions. I guess its whether we want to do it now per example or all at once later for all examples.
Contributor
Author
There was a problem hiding this comment.
just updated this one, will do the others once they've been reviewed and there are no further changes to make (since I can't actually build with the dependency on a not-yet-existing version)
patrickfreed
approved these changes
Feb 21, 2020
kmahar
added a commit
that referenced
this pull request
Feb 21, 2020
kmahar
added a commit
that referenced
this pull request
Feb 26, 2020
kmahar
added a commit
that referenced
this pull request
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Perfect example to use the async API.