Skip to content

Conversation

@patrickfreed
Copy link
Contributor

SWIFT-621

I looked through the rest of our enums (ty jazzy) and didn't see anything else that needed this treatment besides WriteModel.

@patrickfreed patrickfreed requested a review from kmahar April 1, 2020 22:30
@kmahar
Copy link
Contributor

kmahar commented Apr 1, 2020

lgtm, though it just occurred to me we can probably remove options: nil from a lot of places in the bulk write tests now?

@patrickfreed
Copy link
Contributor Author

good point, done

@codecov-io
Copy link

Codecov Report

Merging #439 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #439   +/-   ##
=======================================
  Coverage   77.93%   77.93%           
=======================================
  Files         115      115           
  Lines       12321    12321           
=======================================
  Hits         9602     9602           
  Misses       2719     2719           
Impacted Files Coverage Δ
Sources/MongoSwift/MongoCollection+BulkWrite.swift 91.97% <ø> (ø)
...wiftSyncTests/MongoCollection+BulkWriteTests.swift 97.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e5aee2...c756bf3. Read the comment docs.

@patrickfreed patrickfreed merged commit b6bc5b7 into mongodb:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants